Add verification module that verifies LLM results using CcCEdict and Wikitionary

pytest.ini

@@ -1,2 +1,6 @@
 [pytest]
 pythonpath = src
+
+markers =
+    integration: mark test as an integration test that uses real data or external APIs
+

src/singletons.py

@@ -0,0 +1,3 @@
+from pycccedict.cccedict import CcCedict
+
+CC_DICT = CcCedict()

src/utils/utils.py

@@ -1,7 +1,29 @@
+import requests
 from pypinyin import Style, pinyin
 
+from singletons import CC_DICT
 
 def get_pinyin(text: str):
     """Convert Chinese characters to pinyin with tones."""
     py_list = pinyin(text, style=Style.TONE, heteronym=False)
     return " ".join([syllable[0] for syllable in py_list])
+
+
+def verify_idiom_exists(idiom: str) -> bool:
+    """Verify idiom first via CC-CEDICT, then Wiktionary API."""
+    # Step 1: Local CC-CEDICT lookup
+    if CC_DICT.get_definitions(idiom):
+        return True
+
+    # Step 2: Wiktionary fallback
+    try:
+        url = "https://zh.wiktionary.org/w/api.php"
+        params = {"action": "query", "titles": idiom, "format": "json"}
+        response = requests.get(url, params=params, timeout=3)
+        data = response.json()
+        pages = data.get("query", {}).get("pages", {})
+        return not ("-1" in pages)
+    except Exception:
+        # Network or API failure — assume unknown
+        return False
+    

src/verification/verifier.py

@@ -0,0 +1,14 @@
+from typing import Optional
+from singletons import CC_DICT
+from verification.wiktionary_client import WiktionaryClient
+
+
+def verify_idiom_exists(idiom: str, wiktionary_client: Optional[WiktionaryClient] = None) -> bool:
+    """Verify idiom exists via CC-CEDICT or optional Wiktionary client."""
+    # Step 1: Local CC-CEDICT lookup
+    if CC_DICT.get_definitions(idiom):
+        return True
+
+    # Step 2: Wiktionary fallback
+    client = wiktionary_client or WiktionaryClient()
+    return client.exists(idiom)

src/verification/wiktionary_client.py

@@ -0,0 +1,28 @@
+import requests
+
+
+_WIKTIONARY_CACHE = {}
+
+class WiktionaryClient:
+    """Simple wrapper for Wiktionary API queries."""
+    BASE_URL = "https://zh.wiktionary.org/w/api.php"
+    HEADERS = {"User-Agent": "MyChineseIdiomApp/1.0 ([email protected])"}
+
+    def exists(self, term: str) -> bool:
+        import requests
+
+        if term in _WIKTIONARY_CACHE:
+            return _WIKTIONARY_CACHE[term]
+
+        try:
+            params = {"action": "query", "titles": term, "format": "json"}
+            response = requests.get(self.BASE_URL, params=params, headers=self.HEADERS, timeout=5)
+            response.raise_for_status()
+            data = response.json()
+            pages = data.get("query", {}).get("pages", {})
+            exists = "-1" not in pages
+        except Exception:
+            exists = False
+
+        _WIKTIONARY_CACHE[term] = exists
+        return exists

tests/conftest.py

@@ -0,0 +1,7 @@
+import pytest
+from verification.wiktionary_client import WiktionaryClient
+
+@pytest.fixture
+def wiktionary_client():
+    """Return a real Wiktionary client for integration tests."""
+    return WiktionaryClient()

tests/test_utils.py

@@ -1,6 +1,5 @@
 import pytest
-
-from utils.utils import get_pinyin
+from utils import utils
 
 
 @pytest.mark.parametrize(
@@ -12,4 +11,4 @@ from utils.utils import get_pinyin
     ],
 )
 def test_get_pinyin_accent(text, expected):
-    assert get_pinyin(text) == expected
+    assert utils.get_pinyin(text) == expected

tests/test_verifier_integration.py

@@ -0,0 +1,28 @@
+import pytest
+from verification.verifier import verify_idiom_exists
+from singletons import CC_DICT
+
+
+@pytest.mark.integration
+def test_real_idiom_in_cc_cedict():
+    """Verify a known idiom exists in CC-CEDICT."""
+    idiom = "山珍海味"  # pick a real idiom in your CC_DICT
+    assert verify_idiom_exists(idiom) is True
+
+@pytest.mark.integration
+def test_fake_idiom_not_in_cc_cedict():
+    """Verify a non-existent idiom returns False."""
+    idiom = "不存在的成语"
+    assert verify_idiom_exists(idiom) is False
+
+@pytest.mark.integration
+def test_real_idiom_wiktionary(wiktionary_client):
+    """Verify that a known idiom exists on Wiktionary."""
+    idiom = "成语"
+    assert verify_idiom_exists(idiom, wiktionary_client=wiktionary_client) is True
+
+@pytest.mark.integration
+def test_fake_idiom_wiktionary(wiktionary_client):
+    """Verify that a made-up idiom does not exist on Wiktionary."""
+    idiom = "不存在的成语"
+    assert verify_idiom_exists(idiom, wiktionary_client=wiktionary_client) is False

tests/test_verifier_unit.py

@@ -0,0 +1,49 @@
+import pytest
+from unittest.mock import MagicMock
+import verification.verifier as verifier_module
+from verification.wiktionary_client import WiktionaryClient
+
+class FakeClient:
+    def __init__(self, return_value: bool):
+        self.return_value = return_value
+        self.called_with = None
+
+    def exists(self, idiom: str) -> bool:
+        self.called_with = idiom
+        return self.return_value
+    
+def test_returns_true_if_in_cc_cedict(monkeypatch):
+    """Return True if CC-CEDICT has definitions."""
+    mock_CC_DICT = MagicMock()
+    mock_CC_DICT.get_definitions.return_value = ["dummy definition"]
+
+    # Patch CC_DICT inside verifier module
+    monkeypatch.setattr(verifier_module, "CC_DICT", mock_CC_DICT)
+
+    result = verifier_module.verify_idiom_exists("山珍海味")
+    assert result is True
+    mock_CC_DICT.get_definitions.assert_called_once_with("山珍海味")
+
+
+def test_returns_false_if_not_in_cc_cedict(monkeypatch):
+    """Return False if CC-CEDICT has no definitions and no Wiktionary client."""
+    mock_CC_DICT = MagicMock()
+    mock_CC_DICT.get_definitions.return_value = []
+
+    monkeypatch.setattr(verifier_module, "CC_DICT", mock_CC_DICT)
+
+    result = verifier_module.verify_idiom_exists("不存在的成语")
+    assert result is False
+    mock_CC_DICT.get_definitions.assert_called_once_with("不存在的成语")
+
+
+def test_returns_true_with_wiktionary_fallback(monkeypatch):
+    """Return True if Wiktionary client finds the idiom."""
+    mock_CC_DICT = MagicMock()
+    mock_CC_DICT.get_definitions.return_value = []
+
+    monkeypatch.setattr(verifier_module, "CC_DICT", mock_CC_DICT)
+    wik_client = FakeClient(True)
+
+    result = verifier_module.verify_idiom_exists("非数据集成语", wik_client)
+    assert result is True

utils/utils.py

@@ -1,7 +0,0 @@
-from pypinyin import Style, pinyin
-
-
-def get_pinyin(text: str):
-    """Convert Chinese characters to pinyin with tones."""
-    py_list = pinyin(text, style=Style.TONE, heteronym=False)
-    return " ".join([syllable[0] for syllable in py_list])