Update app.py

app.py

@@ -342,24 +342,19 @@ def get_groq_response(query: str, context: str) -> str:
         logger.error(f"Groq API error: {e}", exc_info=True)
         return f"Error: Unable to get response from AI model. Exception: {str(e)}"
 
+def get_theme():
+    """Get current theme from query parameters"""
+    theme = st.query_params.get("theme", "light")
+    return "dark" if theme == "dark" else "light"
 
-def create_plotly_confidence_chart(results, chart_id):
-    """Create an interactive confidence chart using Plotly with unique ID"""
+def create_plotly_confidence_chart(results, unique_key):
+    """Create an interactive confidence chart using Plotly"""
+    theme = get_theme()
     colors = {
-        'light': {
-            'bg': 'white',
-            'text': 'black',
-            'grid': '#eee'
-        },
-        'dark': {
-            'bg': '#262730',
-            'text': 'white',
-            'grid': '#333'
-        }
+        'light': {'bg': 'white', 'text': 'black', 'grid': '#eee'},
+        'dark': {'bg': '#2d2d2d', 'text': 'white', 'grid': '#444'}
     }
-    
-    theme = 'dark' if st.get_option('theme.base') == 'dark' else 'light'
-    
+
     fig = go.Figure(data=[
         go.Bar(
             x=list(results.values()),
@@ -370,10 +365,10 @@ def create_plotly_confidence_chart(results, chart_id):
             textposition='auto',
         )
     ])
-    
+
     fig.update_layout(
-        title='Defect Detection Confidence Levels',
-        xaxis_title='Confidence',
+        title='Defect Detection Confidence',
+        xaxis_title='Confidence Level',
         yaxis_title='Defect Type',
         template='plotly_dark' if theme == 'dark' else 'plotly_white',
         height=400,
@@ -383,11 +378,13 @@ def create_plotly_confidence_chart(results, chart_id):
         paper_bgcolor=colors[theme]['bg'],
         font=dict(color=colors[theme]['text'])
     )
-    
+
     return fig
 
 def create_defect_card(title, description, severity, repair_method):
-    """Create a styled card for defect information with theme support"""
+    """Create a styled card for defect information"""
+    theme = get_theme()
+    
     severity_colors = {
         "Critical": "#ff4444",
         "High": "#ffa000",
@@ -395,16 +392,19 @@ def create_defect_card(title, description, severity, repair_method):
         "Low": "#4caf50"
     }
     
-    # Get current theme
-    is_dark = st.get_option('theme.base') == 'dark'
-    
-    bg_color = '#1e1e1e' if is_dark else '#ffffff'
-    text_color = '#ffffff' if is_dark else '#000000'
-    border_color = '#333333' if is_dark else '#dddddd'
+    bg_color = '#1e1e1e' if theme == 'dark' else '#ffffff'
+    text_color = '#ffffff' if theme == 'dark' else '#000000'
+    border_color = '#333333' if theme == 'dark' else '#dddddd'
     
     return f"""
-    <div style="border: 1px solid {border_color}; border-radius: 10px; padding: 15px; margin: 10px 0; background-color: {bg_color}; color: {text_color};">
-        <h3 style="color: {'#00a0dc' if is_dark else '#1f77b4'}; margin: 0 0 10px 0;">{title}</h3>
+    <div style="border: 1px solid {border_color}; 
+                border-radius: 10px; 
+                padding: 15px; 
+                margin: 10px 0; 
+                background-color: {bg_color}; 
+                color: {text_color};">
+        <h3 style="color: {'#00a0dc' if theme == 'dark' else '#1f77b4'}; 
+                   margin: 0 0 10px 0;">{title}</h3>
         <p><strong>Description:</strong> {description}</p>
         <p><strong>Severity:</strong> 
             <span style="color: {severity_colors.get(severity, '#808080')}">
@@ -415,80 +415,49 @@ def create_defect_card(title, description, severity, repair_method):
     </div>
     """
 
-def get_theme_specific_styles():
-    """Get theme-specific CSS styles"""
-    is_dark = st.get_option('theme.base') == 'dark'
+def apply_theme_styles():
+    """Apply theme-specific CSS styles"""
+    theme = get_theme()
+    is_dark = theme == "dark"
     
-    if is_dark:
-        return """
-        <style>
-        .stApp {
-            background-color: #0e1117;
-        }
-        .upload-text {
-            border: 2px dashed #444;
-            background-color: #1e1e1e;
-        }
-        .info-box {
-            background-color: #262730;
-            border: 1px solid #333;
-        }
-        .stAlert {
-            background-color: #262730;
-            border: 1px solid #333;
-        }
-        </style>
-        """
-    else:
-        return """
-        <style>
-        .stApp {
-            background-color: #f8f9fa;
-        }
-        .upload-text {
-            border: 2px dashed #ccc;
-            background-color: #ffffff;
-        }
-        .info-box {
-            background-color: #e9ecef;
-            border: 1px solid #dee2e6;
-        }
-        </style>
-        """
+    styles = """
+    <style>
+    .stApp {
+        background-color: """ + ('#0e1117' if is_dark else '#f8f9fa') + """;
+    }
+    .upload-area {
+        text-align: center;
+        padding: 2rem;
+        border-radius: 10px;
+        border: 2px dashed """ + ('#444' if is_dark else '#ccc') + """;
+        background-color: """ + ('#1e1e1e' if is_dark else '#ffffff') + """;
+        margin-bottom: 1rem;
+    }
+    .info-box {
+        padding: 1rem;
+        border-radius: 10px;
+        margin: 1rem 0;
+        background-color: """ + ('#262730' if is_dark else '#e9ecef') + """;
+        border: 1px solid """ + ('#333' if is_dark else '#dee2e6') + """;
+    }
+    .stButton>button {
+        width: 100%;
+    }
+    </style>
+    """
+    st.markdown(styles, unsafe_allow_html=True)
 
 def main():
     st.set_page_config(
-        page_title="Smart Construction Defect Analyzer",
+        page_title="Construction Defect Analyzer",
         page_icon="🏗️",
         layout="wide",
         initial_sidebar_state="expanded"
     )
-    
-    # Apply theme-specific styles
-    st.markdown(get_theme_specific_styles(), unsafe_allow_html=True)
-    
-    # Base CSS that works for both themes
-    st.markdown("""
-        <style>
-        .css-1d391kg {
-            padding: 2rem 1rem;
-        }
-        .stButton>button {
-            width: 100%;
-        }
-        .upload-text {
-            text-align: center;
-            padding: 2rem;
-            border-radius: 10px;
-        }
-        .info-box {
-            padding: 1rem;
-            border-radius: 10px;
-            margin: 1rem 0;
-        }
-        </style>
-    """, unsafe_allow_html=True)
-    
+
+    # Apply theme styles
+    apply_theme_styles()
+
     # Initialize session state
     if 'analyzer' not in st.session_state:
         st.session_state.analyzer = ImageAnalyzer()
@@ -496,168 +465,138 @@ def main():
         st.session_state.rag_system = RAGSystem()
     if 'analysis_history' not in st.session_state:
         st.session_state.analysis_history = []
-    
+
     # Sidebar
     with st.sidebar:
-        colored_header(
-            label="System Controls",
-            description="Settings and Information",
-            color_name="blue-70"
-        )
+        st.title("🔧 Controls")
         
         # Theme selector
         theme = st.selectbox(
-            "Choose Theme",
-            options=["Light", "Dark"],
-            index=1 if st.get_option('theme.base') == 'dark' else 0
+            "Theme",
+            options=["light", "dark"],
+            index=0 if get_theme() == "light" else 1,
+            key="theme_selector"
         )
         
+        if theme != get_theme():
+            st.query_params["theme"] = theme
+            st.rerun()
+
+        st.divider()
+
+        # API Status
         if os.getenv("GROQ_API_KEY"):
-            st.success("🟢 AI System: Connected")
+            st.success("🟢 AI System Connected")
         else:
-            st.error("🔴 AI System: Not configured")
-        
-        add_vertical_space(2)
-        
+            st.error("🔴 AI System Not Connected")
+
         with st.expander("ℹ️ About", expanded=True):
             st.write("""
-            ### Smart Construction Defect Analyzer
+            ### Construction Defect Analyzer
             
-            This advanced tool combines computer vision and AI to:
-            - Detect construction defects in images
-            - Provide detailed repair recommendations
-            - Answer technical questions
-            - Track analysis history
+            Advanced AI-powered tool for:
+            - Visual defect detection
+            - Repair recommendations
+            - Expert consultations
+            - Analysis tracking
             """)
-        
-        with st.expander("🔧 Settings"):
-            if st.button("Clear Analysis History"):
+
+        # Settings
+        with st.expander("⚙️ Settings"):
+            if st.button("Clear History"):
                 st.session_state.analysis_history = []
                 st.cache_data.clear()
                 st.success("History cleared!")
-            
-            confidence_threshold = st.slider(
-                "Detection Confidence Threshold",
-                min_value=0.0,
-                max_value=1.0,
-                value=0.3,
-                step=0.1
-            )
-    
+
     # Main content
-    colored_header(
-        label="Construction Defect Analyzer",
-        description="Upload images and get instant defect analysis",
-        color_name="blue-70"
-    )
+    st.title("Construction Defect Analyzer")
     
-    tab1, tab2, tab3 = st.tabs(["📸 Image Analysis", "❓ Ask Expert", "📊 Analysis History"])
+    tabs = st.tabs(["📸 Analysis", "❓ Expert Help", "📊 History"])
     
-    with tab1:
+    with tabs[0]:  # Analysis Tab
         col1, col2 = st.columns([1, 1])
         
         with col1:
-            st.markdown('<div class="upload-text">', unsafe_allow_html=True)
+            st.markdown('<div class="upload-area">', unsafe_allow_html=True)
             uploaded_file = st.file_uploader(
-                "Drop your construction image here",
-                type=["jpg", "jpeg", "png"],
-                key="image_uploader"
+                "Upload construction image",
+                type=["jpg", "jpeg", "png"]
             )
             st.markdown('</div>', unsafe_allow_html=True)
-            
+
             if uploaded_file:
                 try:
                     with st.spinner('Processing image...'):
-                        processed_image = st.session_state.analyzer.preprocess_image(uploaded_file)
-                        if processed_image:
-                            st.image(processed_image, caption='Analyzed Image', use_column_width=True)
-                            
-                            results = st.session_state.analyzer.analyze_image(processed_image)
+                        image = st.session_state.analyzer.preprocess_image(uploaded_file)
+                        if image:
+                            st.image(image, caption='Analyzed Image', use_column_width=True)
+                            results = st.session_state.analyzer.analyze_image(image)
                             if results:
-                                # Store analysis in history
                                 st.session_state.analysis_history.append({
                                     'timestamp': datetime.now(),
                                     'results': results,
-                                    'image': processed_image
+                                    'image': image
                                 })
                 except Exception as e:
                     st.error(f"Error: {str(e)}")
-        
+
         with col2:
-            if uploaded_file and results:
+            if uploaded_file and 'results' in locals():
                 st.markdown("### Analysis Results")
                 
-                # Interactive confidence chart with unique ID
                 fig = create_plotly_confidence_chart(results, "main_analysis")
                 st.plotly_chart(fig, use_container_width=True, key="main_chart")
                 
-                # Most critical defect
-                most_likely_defect = max(results.items(), key=lambda x: x[1])[0]
-                st.info(f"🔍 Primary Defect Detected: {most_likely_defect}")
+                primary_defect = max(results.items(), key=lambda x: x[1])[0]
+                st.info(f"🔍 Primary Defect: {primary_defect}")
                 
-                # Get detailed information about the defect
-                context = st.session_state.rag_system.get_relevant_context(most_likely_defect)
+                context = st.session_state.rag_system.get_relevant_context(primary_defect)
                 if context:
-                    st.markdown("### Defect Details")
+                    lines = context.split('\n')
                     st.markdown(create_defect_card(
-                        most_likely_defect,
-                        context.split('\n')[2].split(': ')[1],
-                        context.split('\n')[1].split(': ')[1],
-                        context.split('\n')[3].split(': ')[1]
+                        primary_defect,
+                        next((line.split(': ')[1] for line in lines if 'description' in line.lower()), ''),
+                        next((line.split(': ')[1] for line in lines if 'severity' in line.lower()), ''),
+                        next((line.split(': ')[1] for line in lines if 'repair_method' in line.lower()), '')
                     ), unsafe_allow_html=True)
-    
-    with tab2:
-        st.markdown("### Ask the Construction Expert")
-        
-        query_placeholder = "Example: What are the best repair methods for structural cracks?"
-        user_query = st.text_input("Your Question:", placeholder=query_placeholder)
+
+    with tabs[1]:  # Expert Help Tab
+        st.markdown("### Ask Our Expert")
+        query = st.text_input(
+            "Your Question:",
+            placeholder="Example: What are the best repair methods for spalling?"
+        )
         
-        if user_query:
+        if query:
             with st.spinner('Consulting AI expert...'):
-                context = st.session_state.rag_system.get_relevant_context(user_query)
+                context = st.session_state.rag_system.get_relevant_context(query)
                 if context:
-                    response = get_groq_response(user_query, context)
-                    
+                    response = get_groq_response(query, context)
                     if not response.startswith("Error"):
                         st.markdown("### Expert Response")
                         st.markdown(response)
-                        
-                        with st.expander("View Source Information"):
+                        with st.expander("View Source"):
                             st.markdown(context)
                     else:
                         st.error(response)
-    
-    with tab3:
+
+    with tabs[2]:  # History Tab
         if st.session_state.analysis_history:
             for i, analysis in enumerate(reversed(st.session_state.analysis_history)):
-                with st.expander(f"Analysis {i+1} - {analysis['timestamp'].strftime('%Y-%m-%d %H:%M')}"):
-                    col1, col2 = st.columns([1, 1])
-                    with col1:
-                        st.image(analysis['image'], caption='Analyzed Image', use_column_width=True)
-                    with col2:
-                        # Create chart with unique ID for history items
-                        fig = create_plotly_confidence_chart(analysis['results'], f"history_{i}")
-                        st.plotly_chart(fig, use_container_width=True, key=f"history_chart_{i}")
+                with st.expander(
+                    f"Analysis {i+1} - {analysis['timestamp'].strftime('%Y-%m-%d %H:%M')}"
+                ):
+                    cols = st.columns([1, 1])
+                    with cols[0]:
+                        st.image(analysis['image'], caption='Image', use_column_width=True)
+                    with cols[1]:
+                        fig = create_plotly_confidence_chart(
+                            analysis['results'],
+                            f"history_{i}"
+                        )
+                        st.plotly_chart(fig, use_container_width=True, key=f"history_{i}")
         else:
             st.info("No analysis history available")
 
-    # Handle theme change
-    if theme == "Dark" and st.get_option('theme.base') != 'dark':
-        st.markdown("""
-            <script>
-                var elements = window.parent.document.getElementsByTagName('iframe');
-                for (var i = 0; i < elements.length; i++) {
-                    if (elements[i].height === '0') {
-                        elements[i].remove();
-                    }
-                }
-            </script>
-            """, unsafe_allow_html=True)
-        st.experimental_set_query_params(theme='dark')
-        st.experimental_rerun()
-    elif theme == "Light" and st.get_option('theme.base') != 'light':
-        st.experimental_set_query_params(theme='light')
-        st.experimental_rerun()
-
 if __name__ == "__main__":
     main()