Decrease amount of updating leaderboard source data

app.py

@@ -115,7 +115,6 @@ def get_submission_ids_and_titles():
 
 def submit_results():
     leaderboard_server.save_pre_submit()
-    leaderboard_server.update_leaderboard()
     gr.Info('Submission successful!')
     
     with leaderboard_server.var_lock.ro:
@@ -234,8 +233,6 @@ def hide_modal():
 
 
 def on_application_load():
-    leaderboard_server.update_leaderboard()
-    
     with leaderboard_server.var_lock.ro:
         leaderboard = leaderboard_server.get_leaderboard(category=leaderboard_server.TASKS_CATEGORY_OVERALL)
         submission_ids_and_titles = get_submission_ids_and_titles()

server.py

@@ -149,12 +149,6 @@ class LeaderboardServer:
     def __init__(self):
         self.SERVER_ADDRESS = REPO
         self.REPO_TYPE = "dataset"
-        self.results_dataset_local_snapshot = snapshot_download(
-            self.SERVER_ADDRESS,
-            repo_type=self.REPO_TYPE,
-            token=HF_TOKEN,
-            local_dir="./",
-        )
         self.TASKS_METADATA = json.load(open(TASKS_METADATA_PATH))
         self.TASKS_CATEGORIES = {self.TASKS_METADATA[task]["category"] for task in self.TASKS_METADATA}
         self.TASKS_CATEGORY_OVERALL = "Overall"
@@ -165,34 +159,40 @@ class LeaderboardServer:
         self.submission_id_to_file = {}  # Map submission ids to file paths
         self.submission_id_to_model_title = {}
         self.submission_id_to_data = {}  # Only data (results and metadata) using by leaderboard
-        self.fetch_existing_models()
-        self.tournament_results = self.load_tournament_results()
+        self.tournament_results = None
+        
+        self.results_dataset_local_snapshot_lock = ReadWriteLock()
+        self.results_dataset_local_snapshot = None
         
         self.pre_submit_lock = pre_submit_lock
         self.pre_submit = None
         
+        self.update_leaderboard()
         self.results_dataset_integrity_check()  # Check integrity of the results dataset after (re)start Hugging Face Space
 
     def update_leaderboard(self):
-        self.results_dataset_local_snapshot = snapshot_download(
-            self.SERVER_ADDRESS,
-            repo_type=self.REPO_TYPE,
-            token=HF_TOKEN,
-            local_dir="./",
-        )
-        self.fetch_existing_models()
+        with self.results_dataset_local_snapshot_lock.rw:
+            self.results_dataset_local_snapshot = snapshot_download(
+                self.SERVER_ADDRESS,
+                repo_type=self.REPO_TYPE,
+                token=HF_TOKEN,
+                local_dir="./",
+            )
         
+        self.fetch_existing_models()
         tournament_results = self.load_tournament_results()
+        
         with self.var_lock.rw:
             self.tournament_results = tournament_results
 
     def load_tournament_results(self):
-        metadata_rank_paths = os.path.join(self.results_dataset_local_snapshot, "tournament.json")
-        if not os.path.exists(metadata_rank_paths):
-            return {}
-        with open(metadata_rank_paths) as ranks_file:
-            results = json.load(ranks_file)
-        return results
+        with self.results_dataset_local_snapshot_lock.ro:
+            metadata_rank_paths = os.path.join(self.results_dataset_local_snapshot, "tournament.json")
+            if not os.path.exists(metadata_rank_paths):
+                return {}
+            with open(metadata_rank_paths) as ranks_file:
+                results = json.load(ranks_file)
+            return results
 
     def _prepare_category_to_task_abbr_to_details(self):
         tasks_per_category = {}
@@ -224,18 +224,29 @@ class LeaderboardServer:
 
     def fetch_existing_models(self):
         # Models data
-        for submission_file in glob.glob(os.path.join(self.results_dataset_local_snapshot, "data") + "/*.json"):
-            data = json.load(open(submission_file))
-            metadata = data.get('metadata')
-            if metadata is None:
-                continue
-            submission_id = metadata["submission_id"]
-            
-            with self.var_lock.rw:
-                self.submission_ids.add(submission_id)
-                self.submission_id_to_file[submission_id] = submission_file
-                self.submission_id_to_model_title[submission_id] = metadata["team_name"] + "/" + metadata["model_name"]
-                self.submission_id_to_data[submission_id] = {"results": data["results"], "metadata": metadata}
+        submission_ids = set()
+        submission_id_to_file = {}
+        submission_id_to_model_title = {}
+        submission_id_to_data = {}
+        
+        with self.results_dataset_local_snapshot_lock.ro:
+            for submission_file in glob.glob(os.path.join(self.results_dataset_local_snapshot, "data") + "/*.json"):
+                data = json.load(open(submission_file))
+                metadata = data.get('metadata')
+                if metadata is None:
+                    continue
+                submission_id = metadata["submission_id"]
+                
+                submission_ids.add(submission_id)
+                submission_id_to_file[submission_id] = submission_file
+                submission_id_to_model_title[submission_id] = metadata["team_name"] + "/" + metadata["model_name"]
+                submission_id_to_data[submission_id] = {"results": data["results"], "metadata": metadata}
+        
+        with self.var_lock.rw:
+            self.submission_ids = submission_ids
+            self.submission_id_to_file = submission_id_to_file
+            self.submission_id_to_model_title = submission_id_to_model_title
+            self.submission_id_to_data = submission_id_to_data
 
     def results_dataset_integrity_check(self):
         """
@@ -611,6 +622,7 @@ class LeaderboardServer:
                 self._upload_tournament_results(tournament_results)
                 
                 self.pre_submit = None
+                self.update_leaderboard()
 
     def _upload_submission(self, submission_id, file):
         api.upload_file(
@@ -623,9 +635,10 @@ class LeaderboardServer:
 
     def _upload_tournament_results(self, tournament_results):
         # Temporary save tournament results
-        tournament_results_path = os.path.join(self.results_dataset_local_snapshot, "tournament.json")
-        with open(tournament_results_path, "w") as f:
-            json.dump(tournament_results, f, sort_keys=True, indent=2)  # readable JSON
+        with self.results_dataset_local_snapshot_lock.rw:
+            tournament_results_path = os.path.join(self.results_dataset_local_snapshot, "tournament.json")
+            with open(tournament_results_path, "w") as f:
+                json.dump(tournament_results, f, sort_keys=True, indent=2)  # readable JSON
 
         api.upload_file(
             path_or_fileobj=tournament_results_path,