Optimization of the significance correction

server.py

@@ -314,6 +314,7 @@ class LeaderboardServer:
         self.fetch_existing_models()
         
         tournament_results = self.load_tournament_results()
+        tournament_results = self._correct_significance_in_tournament_results(tournament_results)
         with self.var_lock.rw:
             self.tournament_results = tournament_results
     
@@ -519,6 +520,9 @@ class LeaderboardServer:
                         renew_tournament_ended_time_elapsed = renew_tournament_ended_datetime - renew_tournament_began_datetime
                         print(f"Time elapsed: {renew_tournament_ended_time_elapsed}")
                         
+                        gr.Info('Correcting significance in tournament results...', duration=5)
+                        tournament_results = self._correct_significance_in_tournament_results(tournament_results)
+                        
                         gr.Info('Uploading tournament results...', duration=5)
                         if self.tournament_results:
                             self._upload_tournament_results(self.tournament_results)
@@ -569,7 +573,6 @@ class LeaderboardServer:
         
         with self.var_lock.ro:
             tournament_results = pre_submit.tournament_results if pre_submit else self.tournament_results
-            tournament_results = self._correct_significance_in_tournament_results(tournament_results)
             
             for competitor_id in tournament_results[submission_id].keys() - {submission_id}: # without self
                 if competitor_id not in self.submission_id_to_data:
@@ -638,17 +641,28 @@ class LeaderboardServer:
                 dataframe = dataframe.style.apply(self._model_tournament_table_highlight_true_and_false, axis=None)
             return dataframe
 
+    def _is_correct_significance_in_tournament_results(self, tournament_results):
+        for submission_id in tournament_results:
+            competitors = [competitor_id for competitor_id in tournament_results[submission_id].keys() - {submission_id}]  # without self
+            for task in self.TASKS_METADATA:
+                for competitor_id in competitors:
+                    if "corrected_p_value" not in tournament_results[submission_id][competitor_id][task]:
+                        return False
+        
+        return True
+
     def _correct_significance_in_tournament_results(self, tournament_results, alpha=0.05):
         tournament_results = copy.deepcopy(tournament_results)
         
-        for submission_id in tqdm.tqdm(tournament_results):
-            for task in self.TASKS_METADATA:
+        if not self._is_correct_significance_in_tournament_results(tournament_results):
+            for submission_id in tqdm.tqdm(tournament_results):
                 competitors = [competitor_id for competitor_id in tournament_results[submission_id].keys() - {submission_id}]  # without self
-                model_task_pvals = [tournament_results[submission_id][competitor_id][task]["p_value"] for competitor_id in competitors]
-                corrected_model_task_pvals = correct_pvals_for_fdr(model_task_pvals)
-                for competitor_id, task_pval in zip(competitors, corrected_model_task_pvals):
-                    tournament_results[submission_id][competitor_id][task]["corrected_p_value"] = task_pval
-                    tournament_results[submission_id][competitor_id][task]["significant"] = bool(task_pval < alpha)
+                for task in self.TASKS_METADATA:
+                    model_task_pvals = [tournament_results[submission_id][competitor_id][task]["p_value"] for competitor_id in competitors]
+                    corrected_model_task_pvals = correct_pvals_for_fdr(model_task_pvals)
+                    for competitor_id, task_pval in zip(competitors, corrected_model_task_pvals):
+                        tournament_results[submission_id][competitor_id][task]["corrected_p_value"] = task_pval
+                        tournament_results[submission_id][competitor_id][task]["significant"] = bool(task_pval < alpha)
         
         return tournament_results
 
@@ -730,7 +744,6 @@ class LeaderboardServer:
     def _get_leaderboard(self, pre_submit=None, category=None, to_csv=False):
         with self.var_lock.ro:
             tournament_results = pre_submit.tournament_results if pre_submit else self.tournament_results
-            tournament_results = self._correct_significance_in_tournament_results(tournament_results)
             category = category if category else self.TASKS_CATEGORY_OVERALL
 
             if len(tournament_results) == 0:
@@ -1051,6 +1064,7 @@ class LeaderboardServer:
                         tournament_results = self.fake_tournament(submission_id, file)
                     else:
                         tournament_results = self.start_tournament(submission_id, file)
+                        tournament_results = self._correct_significance_in_tournament_results(tournament_results)
                     
                     pre_submit = self.PreSubmit(
                         tournament_results,