Submitted by zanderbyte, also found by 056Security, 0rpse, 0x0107, 0x0bserver, 0x0dd, 0x11singh99, 0x23r0, 0xAadi, 0xAkira, 0xAlipede, 0xAsen, 0xastronatey, 0xauditagent, 0xaudron, 0xAura, 0xfocusNode, 0xhuh2005, 0xiehnnkta, 0xLeveler, 0xMosh, 0xmujahid002, 0xnolo, 0xodus, 0xRajkumar, 0xrex, 0xterrah, 0xvd, 13u9, 4rdiii, Aamir, aariiif, Adotsam, Afriauditor, Agontuk, air_0x, Albort, anonymousjoe, arman, aua_oo7, AvantGard, axelot, backboard9654, Banditx0x, bani, Bauchibred, Bbash, Bluedragon101, brevis, BRONZEDISC, BroRUok, Bz, ccvascocc, ChainSentry, Cli7max, CrazyMoose, crmx_lom, csanuragjain, cylzxje, CyXq, d4r3d3v1l, Daniel_eth, Daniel526, dd0x7e8, debo, Dec3mber, DemoreX, den-sosnowsky, dexcripter, DharkArtz, DoD4uFN, dreamcoder, edwardmintel, ElCid, elolpuer, eLSeR17, EPSec, erictee, eternal1328, ewwrekt, Falendar, federodes, Flare, francoHacker, fromeo_016, gesha17, gregom, gxh191, HardlyDifficult, harry_cryptodev, HChang26, holydevoti0n, honey-k12, hrmneffdii, hyuunn, IceBear, ilchovski, importDev, Incogknito, inh3l, interestingTimes, itsabinashb, JakeFromStateFarm, JCN, jesusrod15, jkk812812, Josh4324, ka14ar, Kalogerone, Kek, King_9aimon, klau5, KupiaSec, kutugu, Lamsy, levi_104, linemi, LLakterian, LonelyWolfDemon, Maglov, mahdifa, Mahi_Vasisth, marwen, miaowu, mtberi, muellerberndt, MukulKolpe, muncentu, mxteem, N0nce, newspacexyz, NexusAudits, nnez, noured23, oakcobalt, octeezy, ok567, Olugbenga, oxelmiguel12, p_crypt0, peanuts, persik228, pfapostol, phoenixV110, Prestige, pulse, PumpkingWok, Punith, queen, RaOne, rare_one, rbserver, Rhaydden, Riceee, rishab, robertauditor, Rolando, rudhra, Ryonen, sabanaku77, safie, sajeevan_58356, Samueltroydomi, seerether, serial-coder, Shahil_Hussain, shaka, Shinobi, Shipkata494, silver_eth, sl1, SmartAuditPro, sohrabhind, Sparrow, spuriousdragon, stuart_the_minion, t0x1c, tachida2k, Tadev, Tamer, teoslaf, Tiannah, Tigerfrake, Timeless, tonitonitoni, Topmark, tpiliposian, Trepid, typicalHuman, udo, udogodwin, Udsen, unique, unnamed, vahdrak1, verboten_viking, victortheoracle, vladi319, vulkan_xx, wellbyt3, Xcrypt, XDZIBECX, YouCrossTheLineAlfie, Z-bra, zraxx, zubyoz, and ZZhelev
LiquidRon.sol#L91
The onlyOperator modifier in LiquidRon contract is intended to restrict access to specific functions to either the owner or operator. Functions like harvest, delegateAmount, and harvestAndDelegateRewards rely on this modifier for access control.  
However, the modifier implementation is incorrect and will always revert when called by any address other than the owner, even if the caller is a valid operator. As a result, operators are completely unable to perform any of their intended actions.
As we can see, if msg.sender is not the owner, the first condition evaluates to true, triggering a revert. Even if we ignore the first condition, when an operator calls a function using this modifier, operator[msg.sender] evaluates to true, causing the revert to be triggered again.
Paste the following test in LquidRon.operator.t.sol:
The modifier should revert only if the msg.sender is neither the owner nor an operator:
Owl (Liquid Ron) confirmed and commented:
0xsomeone (judge) decreased severity to Medium and commented:
Liquid Ron mitigated:
Status: Mitigation confirmed. Full details in reports from Aamir, 0rpse, and ilchovski.
For this audit, 17 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by IlIlHunterlIlI received the top score from the judge.
The following wardens also submitted reports: 0x23r0, 0xAadi, 0xodus, 0xrex, atoko, Bauchibred, Bigsam, Daniel526, inh3l, K42, Kalogerone, magiccentaur, pfapostol, rbserver, Rhaydden, and Sparrow.
