Submitted by Evo
https://github.com/code-423n4/2024-12-lambowin/blob/b8b8b0b1d7c9733a7bd9536e027886adb78ff83a/src/rebalance/LamboRebalanceOnUniwap.sol#L62
The profit > 0 requirement in the rebalance function actively prevents the protocol from maintaining the VETH/WETH 1:1 peg during unprofitable market conditions, when profit is ZERO.
The protocol documentation and teams design goals that the RebalanceOnUniswap contract is specifically designed to maintain the VETH/WETH pool ratio at 1:1, intentionally accepting gas losses as a trade-off for improved price stability.
It is mentioned in the previous audit, In the sponsors acknowledgement (from SlowMist audit, N12):
However, in LamboRebalanceOnUniwap.sol#L68:
The require(profit > 0) check means:
An example scenario would be:
Update the require(profit > 0) to require(profit >= 0).
Shaneson (Lambo.win) acknowledged
