Submitted by alix40, also found by 0xKann, 0xlucky, 0xpetern, 0xvd, ABAIKUNANBAEV, Abhan, air_0x, zanderbyte, bharg4v, DharkArtz, dic0de, Hajime, hals, inh3l, John_Femi, kodyvim, lightoasis, Matin, mgf15, MSaptarshi, Mushow, newspacexyz, NexusAudits, PolarizedLight, Rhaydden, Shinobi, smbv-1923, Sparrow, tpiliposian, Tumelo_Crypto, udo, vesko210, waydou, and y51r
Even though there is no frontrunning on L2s, which could mitigate some of the MEV attacks, without defined slippage and in case of congestions the swap could be executed at unfavorable conditions presenting losses for users.
https://github.com/code-423n4/2024-12-flex-perpetuals/blob/b84a0812c3368866964b8a16e7c36f6e7a50b655/src/extensions/dexters/AerodromeDexter.sol#L54-L56
Having the minAmountOut set to 0, will make sure that the swap will always be executed no matter the market condions.
We recommend allowing users to set their desired slippage params.
0xRobocop (validator) commented:
fpcrypto-y (Flex Perpetuals) disputed and commented:
0xsomeone (judge) commented:
