Submitted by klau5
https://github.com/code-423n4/2024-12-bakerfi/blob/0daf8a0547b6245faed5b6cd3f5daf44d2ea7c9a/contracts/core/Vault.sol#L177
https://github.com/code-423n4/2024-12-bakerfi/blob/0daf8a0547b6245faed5b6cd3f5daf44d2ea7c9a/contracts/core/MultiStrategyVault.sol#L174
When the contract is paused, rebalance is not paused. While users cannot withdraw, performance fees can still be collected from interest.
The rebalance should not be callable when paused (according to the documentation), but it can still be called even when paused. This means that while users cannot withdraw their investments from the Vault when paused, its still possible to collect performance fees on interest through the rebalance function. Also, MultiStrategyVault has the same issue.
Add the whenNotPaused modifier to the rebalance function.
chefkenji (BakerFi) confirmed
BakerFi mitigated:
Status: Mitigation confirmed. Full details in reports from 0xlemon and shaflow2.
