Submitted by 0xpiken, also found by 0xlemon, klau5, and shaflow2
When a new strategy is added through MultiStrategy#addStrategy(), it was not approved to spend the asset in MultiStrategyVault. Any functions that call newStrategy#deploy() may revert and result in MultiStrategyVault being DoSed.
MultiStrategyVault is used to manage multiple investment strategies. A new strategy can be added through MultiStrategy#addStrategy():
However, the new strategy was not approved to spend the asset in MultiStrategyVault, resulting MultiStrategyVault being DoSed.
Copy below codes to VaultMultiStrategy.ts and run npm run test:
As we can see, the new strategy has zero allowance.
The new strategy should be approved with max allowance when added:
chefkenji (BakerFi) confirmed
BakerFi mitigated:
Status: Mitigation confirmed. Full details in reports from 0xlemon and shaflow2.
