Submitted by ABAIKUNANBAEV, also found by ABAIKUNANBAEV and zhaojie
At the moment, resolver is not initialized in the feemarket/keeper resulting in a situation where ante from the skip-mev would use its own ConvertToDenom() and not the one initialized in the Mantra protocol.
Mantra chain currently uses its own implementation of the ConvertToDenom() function:
https://github.com/code-423n4/2024-11-mantra/blob/main/x/xfeemarket/keeper/resolver.go#L11-23
The problem is that its not initialized in the Keeper struct:
https://github.com/code-423n4/2024-11-mantra/blob/main/x/xfeemarket/keeper/keeper.go#L14-30
Therefore, when ante decorator from the skip-mev would have to use the resolver, it would use its own one instead of the one implemented in the protocol:
https://github.com/skip-mev/feemarket/blob/main/x/feemarket/keeper/keeper.go#L28-49
This creates a scenario where protocols newly implemented functionality for denom conversions to support multiple coin fee market cannot be used.
Initialize the resolver in the feemarket/keeper.go.
3docSec (judge) commented:
Lance Lan (MANTRA) disputed and commented:
3docSec (judge) commented:
ABAIKUNANBAEV (warden) commented:
3docSec (judge) commented:
For this audit, 5 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by gxh191 received the top score from the judge.
The following wardens also submitted reports: Bauchibred, crypticdefense, Rhaydden, and Sparrow.
