Submitted by Tigerfrake
In the swap_internal() function, the slippage check uses the || operator to validate the swap results. This can lead to a scenario where one of the amounts (amount_0_abs or amount_1_abs) is allowed to be zero, potentially resulting in unwanted slippage.
Using the || operator allows the swap to proceed even if one of the amounts is zero, which could lead to unacceptable slippage.
Scenario:
Using the || operator means that one token amount can be zero while the other passes the check, leading to an imbalanced swap that might not meet user expectations.
Replace the || operator with the && operator to ensure both token amounts are greater than zero.
Invalid Validation
af-afk (Superposition) confirmed
0xsomeone (judge) commented:
af-afk (Superposition) commented:
For this audit, 3 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by Rhaydden was marked as best from the judge and is included for completeness. 
The following wardens also submitted reports: Tigerfrake and rare_one.
