Submitted by nnez
Users veNFT might be temporarily undetachable, preventing users from performing action on their own veNFT.
When users invoke dettachFromManagedNFT to get their veNFT back from ManagedNFT, _poke is called at the end of the function to update voting power across gauges voted by this ManagedNFT.
_poke loads a list of pools and weights voted by ManagedNFT then recast votes again to the same set of pools and weights via calling into _vote. However, _vote reverts when one of the pool/gauge has already been killed.
Now consider this situation:
As a result, users veNFT might be temporarily undetachable when the described scenario happens.
Users are expected to only include active pools in normal vote flow. If one of the pool is inactive, we can safely set its weight to zero and skip over it (gracefully, ignore it).
DoS
b-hrytsak (Fenix) confirmed and commented:
