Submitted by klau5, also found by 0x37, Topmark, Draiakoo, jesjupyter, rbserver, gesha17, Breeje, SBSecurity, and 0xNirix
The required_validators in SettlementSignatureVerifier is not updated when updating BaseSettlements. This results in either fewer or more signatures being required when verified.
The functions BaseSettlement.add_validator and BaseSettlement.remove_validator in the BaseSettlement contract also update the validators of the SignatureVerifier contract. However, the function BaseSettlement.set_required_validators_num does not call SettlementSignatureVerifier.set_required_validators_num. Therefore, the number of required validator signatures will not be set.
This is the PoC. You can add it to solidity/settlement/test/ChakraSettlement.ts and run it.
Call SettlementSignatureVerifier.set_required_validators_num at BaseSettlement.set_required_validators_num .
pidb (Chakra) disputed
0xsomeone (judge) commented:
For this audit, 46 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by SBSecurity received the top score from the judge.
The following wardens also submitted reports: AllTooWell, fyamf, ABAIKUNANBAEV, atoko, Abdessamed, NexusAudits, peanuts, rbserver, calfun0x, Rhaydden, PolarizedLight, 0xNirix, jasonxiale, sivanesh_808, devival, Bauchibred, Sparrow, Breeje, Sabit, Tigerfrake, BY_DLIFE, Nexarion, King_, DPS, VulnViper, Draiakoo, Audinarey, Flare, jesjupyter, Omik, Sisi, Taiger, MrPotatoMagic, minato7namikazi, mrjorystewartbaxter, Trooper, m4k2, LuarSec, klau5, said, Shaheen, haxatron, shaflow2, mojito_auditor, and 4rdiii.
