https://github.com/code-423n4/2024-07-traitforge/blob/279b2887e3d38bc219a05d332cbcb0655b2dc644/contracts/NukeFund/NukeFund.sol#L168-L173
The nuke function in the NukeFund contract does not enforce the relationship between maxAllowedClaimDivisor and nukeFactorMaxParam. This relationship is crucial for the proper calculation of the claimAmount. If these variables are not set correctly, it can lead to incorrect or unexpected behavior in the nuke process, potentially resulting in incorrect distribution of funds.
In the nuke function, the claimAmount is calculated based on whether finalNukeFactor exceeds nukeFactorMaxParam:
The implicit relationship is:
However, both maxAllowedClaimDivisor and nukeFactorMaxParam are set independently without enforcing this constraint:
Ensure that the relationship between maxAllowedClaimDivisor and nukeFactorMaxParam is maintained when setting these values. This can be done by modifying the setter functions to enforce the constraint.
