https://github.com/code-423n4/2024-07-traitforge/blob/279b2887e3d38bc219a05d332cbcb0655b2dc644/contracts/EntityForging/EntityForging.sol#L49-L54
The function fetchListings initializes an array of listingCount + 1 but only fills elements from index 1 to listingCount, leaving the first element uninitialized. This off-by-one issue can cause confusion and may lead to unexpected behavior when the function is used.
Additionally, if listings are deleted via the cancelListingForForging function, the corresponding elements in the listings array become uninitialized or hold no value, further complicating the data returned by fetchListings.
Also, since the listing is unbounded (grows over time) and is looped. When there are so many listings, this could cause performance issues (DOS) or OOG(out-of-gas) issues when all previous listings are retrieved.
