https://github.com/code-423n4/2024-07-traitforge/blob/279b2887e3d38bc219a05d332cbcb0655b2dc644/contracts/TraitForgeNft/TraitForgeNft.sol#L22-L25
https://github.com/code-423n4/2024-07-traitforge/blob/279b2887e3d38bc219a05d332cbcb0655b2dc644/contracts/EntityForging/EntityForging.sol#L37-L48
In the project, several parameters such as maxTokensPerGen, startPrice, priceIncrement, and priceIncrementByGen are designed to be constants:
However, these parameters, along with others like maxGeneration and rootHash, can be modified by the contract owner:
Allowing these parameters to be changed midway through the contracts owners operation can lead to several unexpected consequences:
To note, this is also the same in other contracts like EntityForging:
To note, this is also the same in other contracts like NukeFund:
To mitigate, re-assess whether these parameters need to be modifiable. If they are intended to be constants, enforce immutability to avoid potential issues caused by centralized operations.
