Submitted by merlinboii, also found by Abdessamed, dontonka, araj, Utsav, MrPotatoMagic, dhank, prapandey031, DemoreX, santipu_, 0xCiphky, 0xrex, ke1caM, and dimulski
The LandManager::stakeMunchable() does not verify whether the plotMetadata[landlord] is set or not.
Since the LockManager contract is already deployed on-chain (0xEA091311Fc07139d753A6BBfcA27aB0224854Bae (Blast)), accounts that have locked their tokens before the LandManager deployment will need to trigger LandManager::triggerPlotMetadata() to update their LandManager.plotMetadata after the LandManager is deployed.
The current AccountManager interacts with the LockManager on-chain but does not introduce interaction with the LandManager during AccountManager::forceHarvest().
As a result, users can stake their tokens on land with a 0% tax rate if the landlord has not updated their plotMetadata and farm schnibbles without paying tax to the landlord until the landlords plot metadata is initialized in the LandManager contract (via triggerPlotMetadata() and updatePlotMetadata()).
Users can farm schnibbles on plots with a 0% tax rate without paying any tax to the landlord, which disrupts the platforms revenue model and incentives.
Prerequisites:
This currentTaxRate will not apply to Alices toilerState until Alice farms.
During the schnibblesLandlord calculation, Alices _toiler.latestTaxRate (which was 0) will be used, even though Bob updated the currentTaxRate at block-12.
Result: Alice benefits by retrieving the full schnibblesTotal from block-11 until block-31, even though Bob updated his plotMetadata immediately after Alice staked.
Apply unset plotMetadata.currentTaxRate checks in the LandManager::stakeMunchable():
Invalid Validation
0xsomeone (judge) commented:
merlinboii (warden) commented:
0xsomeone (judge) commented:
0xinsanity (Munchables) acknowledged and commented:
For this audit, 3 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by Rhaydden received the top score from the judge.
The following wardens also submitted reports: dimulski and peanuts.
