Submitted by nnez
Users funds loss from ERC4626 exchange rate change or manipulated.
If users specify collateralParams.targetToken as ERC4626s underlying token, PositionAction4626 will attempt to deposit the targetToken to ERC4626 vault in order to retrieve the collateral token corresponding to the CDP Vault.
The execution flow:
See PositionAction._deposit
Here is the implementation used to convert from ERC4626s underlying to ERC4626 token:
See PositionAction4626._onDeposit
In this implementation, there is no slippage check when performing a deposit on target ERC4626s vault. This could leads to users fund loss from slippage as ERC4626s exchange rate can change or be manipulated while users transaction is pending.
This also happens in withdraw execution flow:
If users specify a different dst (destination) token, it attempts to redeem that token from ERC4626 vault.
Allow users to specify their slippage tolerance when interacting with PositionAction4626.
EIPS
ERC4626
amarcu (LoopFi) confirmed and commented:
Koolex (judge) decreased severity to Medium
Infect3d (warden) commented:
nnez (warden) commented:
Infect3d (warden) commented:
nnez (warden) commented:
Infect3d (warden) commented:
Koolex (judge) commented:
For this audit, 23 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by Bauchibred received the top score from the judge.
The following wardens also submitted reports: Rhaydden, pkqs90, K42, inh3l, 0xhacksmithh, Afriauditor, Trooper, chaduke, Agontuk, atoko, peanuts, minglei-wang-3570, Sparrow, Kaysoft, Spearmint, Infect3d, 0xpiken, Centaur, jo13, hash, ustas, and novamanbg.
