Submitted by lian886, also found by novamanbg
The amount of funds that users can withdraw decreases, leading to a loss of funds for users.
We can see that AuraVault::redeem() confuses AuraVaults shares with rewardPools shares. AuraVaults shares need to be converted into AuraVaults underlying tokens (assets) before they can be withdrawn. This is particularly problematic because, as we know from the rewardPool contract address, rewardPool::redeem() functions the same way as rewardPool::withdraw().
https://vscode.blockscan.com/ethereum/0x00A7BA8Ae7bca0B10A32Ea1f8e2a1Da980c6CAd2
Moreover, in the rewardPool, the ratio of share to asset is always 1:1.
Scenario Example:
Lets assume that in AuraVault, the ratio of share to asset is always 1:2. In this case, if a user withdraws 1 share, they will ultimately receive only 1 asset; whereas, they should have received 2 assets.
Error
amarcu (LoopFi) acknowledged and commented:
