Unlike the Vault.deposit(uint256 assets, address to, uint256 minSharesOut) function that includes the minSharesOut input for slippage control, the Vault.mint and Vault.finishRedeem functions do not have similar inputs for slippage controls. When the staker is an EOA, the previewMint and Vault.mint functions need to be called in separate transactions, and the previewRedeem and Vault.finishRedeem functions need to be called in separate transactions. When malicious frontrunnings that manipulate the vaults exchange rates occur, calling the Vault.mint function can cause the staker to send more underlying tokens than expected to the vault, and calling the Vault.finishRedeem function can cause the staker to receive less underlying tokens than expected from the vault.
Moreover, according to https://eips.ethereum.org/EIPS/eip-4626#security-considerations, If implementors intend to support EOA account access directly, they should consider adding an additional function call for ``deposit``/``mint``/``withdraw``/``redeem`` with the means to accommodate slippage loss or unexpected deposit/withdrawal limits, since they have no other means to revert the transaction if the exact output amount is not achieved. Hence, having no slippage controls in the Vault.mint and Vault.finishRedeem functions is also EIP-4626 non-compliant.
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Vault.sol#L94-L103
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Vault.sol#L110-L119
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Vault.sol#L157-L188
The Vault.mint and Vault.finishRedeem functions can be updated to include inputs for slippage controls.
