The following pauseVault function of the Core contract can be called to pause the Vault contracts deposit, mint, startRedeem, and finishRedeem functions. Also, the Vault contracts withdraw and redeem functions below always revert. Since the Vault contract inherits soladys ERC4626 contract, calling the Vault contracts maxDeposit, maxMint, maxRedeem, and maxWithdraw functions would not return 0 even when the respective deposit, mint, startRedeem, and finishRedeem functions are paused and withdraw and redeem functions always revert.
As specified in https://eips.ethereum.org/EIPS/eip-4626:
Hence, these maxDeposit, maxMint, maxRedeem, and maxWithdraw functions should return 0 when the respective deposit, mint, startRedeem, and finishRedeem functions are paused and withdraw and redeem functions always revert but that is not the case currently. As a result, these maxDeposit, maxMint, maxRedeem, and maxWithdraw functions are not compliant with the EIP-4626 standard.
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Core.sol#L197-L199
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Vault.sol#L331-L362
https://github.com/code-423n4/2024-07-karak/blob/53eb78ebda718d752023db4faff4ab1567327db4/src/Vault.sol#L5-L29
https://github.com/vectorized/solady/blob/main/src/tokens/ERC4626.sol#L326-L359
The Vault contract can be updated to add the maxDeposit, maxMint, maxRedeem, and maxWithdraw functions to override the corresponding functions in soladys ERC4626 contract in which these maxDeposit, maxMint, maxRedeem, and maxWithdraw functions would return 0 when the respective deposit, mint, startRedeem, and finishRedeem functions are paused and withdraw and redeem functions always revert.
