Submitted by 0xSwahili
The Dispenser contract provides functionality for the owner to update manager accounts at any time, including changing the VoteWeighting contract.
Changing the VoteWeighting contract mid-flight can lead to lost staking incentives due to mapLastClaimedStakingEpochs state reset to the current epoch.
Consider the following scenario:
Now, when claimStakingIncentives is called for Nominee X, staking incentives for 2 epochs will have been lost.
For a coded POC:
Add code to Dispenser::changeManagers to check that no Nominee exists when changing the VoteWeighting contract to a new one.
Invalid Validation
kupermind (Olas) disputed and commented:
0xA5DF (judge) decreased severity to Medium and commented:
kupermind (Olas) commented:
0xA5DF (judge) commented:
kupermind (Olas) acknowledged and commented:
Olas mitigated:
Varun_05 (warden) commented:
