Submitted by robertodf99, also found by Bauchibred (1, 2), Rushkov_Boyan, EaglesSecurity, twcctop, araj, Mahmud, typicalHuman, Topmark, Bbash, adam-idarrha, Bigsam, crypticdefense, 0xAadi, 0xdice91, Dots, xyz, iamandreiski, leegh, John_Femi, dhank, joaovwfreire, Eeyore, RotiTelur, Tychai0s, unique, avoloder, 0xleadwizard, AgileJune, swizz, djanerch, Sabit, Utsav, Evo, prapandey031, Stormreckson, mitko1111, Beosin, brevis, dd0x7e8, trachev, pfapostol, aslanbek, Sentryx, falconhoof, carrotsmuggler, ZdravkoHr, ZanyBonzy, bigtone, Walter, EPSec, 0xhacksmithh, MrPotatoMagic, pamprikrumplikas, brgltd, 0xAkira, and merlinboii
Due to the missing disapproval check, a price feed can both disapprove and subsequently approve a newly proposed price. Price feeds are intended to vote either for approval or disapproval, not both. Hence, this can be considered an unintended functionality.
Add a check to see if the price feed has already disapproved the price proposal. If so, revert with a custom error.
0xinsanity (Munchables) confirmed and commented via duplicate issue #83:
0xsomeone (judge) confirmed and commented:
Note: For full discussion, see here.
