Submitted by SpicyMeatball, also found by dontonka and josephdara
An error in the BOLDUpgradeAction.sol contract prevents it from upgrading and deploying new BOLD contracts.
The perform function serves as the entry point in the BOLDUpgradeAction.sol and is responsible for migrating stakers from the old rollup and deploying the challenge manager with a new rollup contract.
One of the first subroutines in this function is the cleanupOldRollup().
This subroutine pauses the old rollup contract and attempts to refund existing stakers.
This function contains a bug that prevents execution of the subsequent procedures. Lets check the forceRefundStaker in the old rollup contract.
According to: https://docs.arbitrum.io/build-decentralized-apps/reference/useful-addresses
Proxy: https://etherscan.io/address/0x5eF0D09d1E6204141B4d37530808eD19f60FBa35
Implementation: https://etherscan.io/address/0x72f193d0f305f532c87a4b9d0a2f407a3f4f585f#code
RollupAdminLogic.sol
RollupCore.sol
From the above code, it is evident that the stakers address is eventually deleted from the _stakerList, causing the array to shrink. As a result, the cleanupOldRollup function will throw an array out-of-bounds error because it tries to iterate through an array with the original number of elements.
Coded POC
Here we use mainnet fork with only the cleanupOldRollup function.
Foundry
godzillaba (Arbitrum) confirmed
gzeoneth (Arbitrum) commented:
Picodes (judge) commented:
For this audit, 23 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by Sathish9098 received the top score from the judge.
The following wardens also submitted reports: ladboy233, Rhaydden, dontonka, K42, slvDev, Dup1337, xuwinnie, SpicyMeatball, bronze_pickaxe, fyamf, hihen, ZanyBonzy, forgebyola, Takarez, twcctop, Audinarey, josephdara, guhu95, zanderbyte, carlitox477, LessDupes, and KupiaSec.
