Submitted by fyamf, also found by tapir, 0xCiphky (1, 2), LessDupes, ladboy233, guhu95, t0x1c, and grearlake
If the xReceive function fails to handle reverts properly, it could result in funds getting stuck. This can happen for example when:
Failure to handle errors in the xReceive function as outlined by Connext can lead to funds becoming inaccessible. See here.
This can happen in several scenarios within the xRenzoBridge contract:
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Bridge/L1/xRenzoBridge.sol#L175
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/RestakeManager.sol#L510
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Bridge/L2/xRenzoDeposit.sol#L168
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Bridge/L2/xRenzoDeposit.sol#L204
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Bridge/L1/xRenzoBridge.sol#L175
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/RestakeManager.sol#L565
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Oracle/RenzoOracle.sol#L146
To address these potential failures, it is suggested to:
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Bridge/L2/xRenzoDeposit.sol#L414
Context
jatinj615 (Renzo) acknowledged
Blckhv (warden) commented:
sin1st3r__ (warden) commented:
Note: for full discussion, see here.
