Submitted by Fassi_Security
Renzo uses CCIP to send price updates from L1 -> L2 using:
The CCIP architecture allows for simultaneous CCIP calls to be made from one address.
However, there is a caveat. As per Chainlink Docs, under the second header:
If a message fails, it can be manually executed, but after the Smart Execution time window expires, which is 8 hours at the moment, all subsequent messages will fail until the failing message will succeed.
The problem is that on the L2 side of things, in CCIPReceiver.sol, the reverts are not handled gracefully. This can easily lead to a CCIP call that can never be executed, thus resulting in a Denial of Service.
These are the failure points during the _ccipReceive() call, that can lead to a CCIP call not being able to be delivered, called by a honest party, marked by an arrow inside _updatePrice:
For example, if the price deviates more than 10%, the delivery will fail. If this delivery keeps failing, even after the 8 hours Smart Execution window has elapsed, the CCIP pathway will be DoSed until this CCIP call successfully delivers.
The impact is broad - price data will be corrupted, minting prices will not be calculated correctly and updates from L1 will be DoSed.
As per the Chainlink docs linked in the report:
Handle the reverts gracefully.
Timing
bronze_pickaxe (warden) commented:
EV_om (warden) commented:
bronze_pickaxe (warden) commented:
jatinj615 (Renzo) acknowledged and commented:
alcueca (judge) commented:
Note: For full discussion, see here.
