Submitted by zigtur, also found by Sathish9098, LessDupes, tapir, xg, t0x1c, rbserver (1, 2), guhu95, eeshenggoh, TECHFUND, TheFabled, cu5t0mpeo, 0xCiphky, ladboy233, NentoR, 0xBeastBoy, ilchovski, bigtone, josephdara (1, 2), FastChecker, mt030d, ak1, 0x73696d616f, Aymen0909, and oakcobalt
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Withdraw/WithdrawQueue.sol#L13
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Withdraw/WithdrawQueue.sol#L206
https://github.com/code-423n4/2024-04-renzo/blob/main/contracts/Withdraw/WithdrawQueue.sol#L279
Administrator is not able to pause users withdrawals and claims as expected.
The WithdrawQueue contract inherits PausableUpgradable to provide pausing capabilities to the administrator on users withdrawals and claims.
The contract correctly exposes the _pause() and _unpause() internal functions through access restricted external functions.
However, none of the functions implement the whenNotPaused modifier. This is especially problematic for user-accessible functions: withdraw and claim.
Consider implementing whenNotPaused modifier on claim and withdraw functions. The following patch implements such a fix.
Note: The patch can be applied with git apply.
Context
jatinj615 (Renzo) confirmed
Renzo mitigated
Status: Mitigation confirmed. Full details in reports from 0xCiphky, grearlake, Fassi_Security, LessDupes, and Bauchibred.
