Submitted by petro_1912, also found by Joshuajee
https://github.com/code-423n4/2024-04-panoptic/blob/main/contracts/CollateralTracker.sol#L247-L251
https://github.com/code-423n4/2024-04-panoptic/blob/main/contracts/CollateralTracker.sol#L261-L263
Swap commission is paid on the intrinsic value based on s_ITMSpreadFee in CollateralTracker contract.
If s_ITMSpreadFee is zero, then swap commission can not be paid.
As you can see above code snippet, if fee(Uniswap fee) is below 100, then _poolFee and s_ITMSpreadFee can be zero.
Currently, there are no such pools that have below 0.01% fee on the UniswapV3.
But Uniswap fee level can be adjusted by the governance proposal like November 2021.
Here is the mention about it in Uniswap Protocol:
https://dune.com/jcarnes/The-StableSwap-Wars
Competitions between Protocols like Uniswap and Carbon, more fee levels can be added in the future.
Indeed, there are several discussions on the less fee levels in stable coins pair.
https://gov.bancor.network/t/custom-taker-fee-on-stable-to-stable-trades/4370
If protocol fee is less than 100 (i.e fee < 0.01 %), then PanopticPools swap commission can not be taken.
Use Uniswaps DECIMALS (1e6) instead 10_000 and update all code related to DECIMALS.
Uniswap
dyedm1 (Panoptic) confirmed
Picodes (judge) commented:
