Submitted by bin2chen
owner can submit getPendingBaseInterestAllocator first, and then anyone can enable it by confirmBaseInterestAllocator().
The current logic is:
If the old BaseInterestAllocator already has a large balance, the balance of the Pool will increase dramatically. Subsequent users executing reallocate() will get a big bonus getReallocationBonus.
Assuming old BaseInterestAllocator balance: 1 M:
shares = 1 M * (1 - optimalIdleRange.mid) * totalSupply * getReallocationBonus / totalAssets()
After change, BaseInterestAllocator may pay large getReallocationBonus.
Execute _reallocate() in the confirmBaseInterestAllocator() method without paying any getReallocationBonus.
Context
0xend (Gondi) confirmed
0xA5DF (judge) decreased severity to Medium and commented:
Gondi mitigated:
Status: Mitigation confirmed. Full details in reports from oakcobalt and bin2chen.
