https://github.com/code-423n4/2024-04-dyad/blob/4a987e536576139793a1c04690336d06c93fca90/src/core/Vault.kerosine.unbounded.sol#L50-L68
This function is used to get the price of an asset, and it gets that by querying the specific vault of that asset for its balance and price.
Keep in mind that this function is also used whenever getting price from the bounded vault as shown here.
Going back to the VaultManagerV2.sol, we can see that the line usdValue = vault.getUsdValue(id); is queried whenever there is a need to get the collateral ratio for asset as confirmed by this search command and queries the two aforementioned functions as shown here.
That is to say that the pricing logic requires us to query chainlink at the end of the calls, but evidently, we can see that this call lacks any check on the in-aggregator built min/max circuits; which would make protocol either overvalue or undervalue the collateral depending on which boundary is crossed.
A little bit more on the min/max circuits is that, Chainlink price feeds have in-built minimum & maximum prices they will return; if during a flash crash, bridge compromise, or depegging event, an assets value falls below the price feeds minimum price, the oracle price feed will continue to report the (now incorrect) minimum price, so an an attacker could:
Borderline medium/low, as this essentially breaks core functionalities like documented collateralization level of DYAD to always be > 150%, and in severe cases, this could even cause the DYAD to depeg.
Store the assets min/max checks, reimplement the way vault.getUsdValue() is being queried and have direct access to the price data being returned and check if its at these boundaries and revert or alternatively integrate a fallback oracle and then use the price from this instead.
