Submitted by carrotsmuggler, also found by 0xabhay, Timenov, and Omik
The function depositWithPermit in the PrizeVault.sol contract is used with permit options so that users can submit a signed message. They then can use that to give allowance to the contract to extract the tokens required for the deposit.
The issue is that the test suite shows that the protocol aims to use sDAI, the dai savings rate, but the DAI tokens permit signature is different. From the contract at address 0x6B175474E89094C44Da98b954EedeAC495271d0F, we see the permit function:
Due to the missing nonce field, DAI, a token which allows permit based interactions, cannot be used with signed messages for depositing into sDAI vaults. Due to the wrong parameters, the permit transactions will revert.
It is evident from the code that the permit function call does not match the signature of DAIs permit function.
For the special case of DAI token, allow a different implementation of the permit function which allows a nonce variable.
Token-Transfer
trmid (PoolTogether) acknowledged and commented:
Infect3d (warden) commented:
hansfriese (judge) commented:
For this audit, 7 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by 0xmystery received the top score from the judge.
The following wardens also submitted reports: d3e4, slvDev, Al-Qa-qa, Tripathi, ZanyBonzy, and dvrkzy.
