Submitted by d3e4
maxDeposit() might return a value greater than can be deposited, violating EIP-4626.
maxDeposit() returns up to yieldVault.maxDeposit(address(this)). However, _depositAndMint() deposits using yieldVault.mint() which may have a stricter limit than yieldVault.deposit(). In that case depositing maxDeposit() would revert, which violates EIP-4626.
Use yieldVault.previewRedeem(yieldVault.maxMint()).
ERC4626
hansfriese (judge) decreased severity to Low and commented:
d3e4 (warden) commented:
hansfriese (judge) increased severity to Medium and commented:
trmid (PoolTogether) acknowledged and commented:
