Note: At the judges request here, this downgraded issue from the same warden has been included in this report for completeness.
If a market is removed from the whitelist before a user claims the reward, users cannot claim it, and the reward will remain stuck.
When users want to claim the reward from LendingLedger by calling claim, it will trigger update_market first before contract sending the reward to users.
https://github.com/code-423n4/2024-03-neobase/blob/main/src/LendingLedger.sol#L122
Inside update_market, if the market is not whitelisted, the call will revert.
https://github.com/code-423n4/2024-03-neobase/blob/main/src/LendingLedger.sol#L65
This could lead to an issue, if the market is removed from the whitelist before users can claim the reward, they cannot claim it, and the reward will remain stuck inside LendingLedger.
Consider to allow users provide additional flag param when calling claim so they can claim reward without triggering update_market.
Invalid Validation
OpenCoreCH (Neobase) acknowledged and commented:
0xTheC0der (judge) decreased severity to Low and commented:
For this audit, 2 reports were submitted by wardens detailing gas optimizations. The report highlighted below by rvierdiiev received the top score from the judge.
The following wardens also submitted reports: Arabadzhiev.
