In the buyShares function, both the base and quote tokens are deposited in the same ratio, and the shares are calculated accordingly.
https://github.com/code-423n4/2024-03-abracadabra-money/blob/1f4693fdbf33e9ad28132643e2d6f7635834c6c6/src/mimswap/MagicLP.sol#L397-L400
If a user deposits one token in a higher ratio than the other, the excess amount cannot be used for calculating shares.
This means users may lose these funds.
To mitigate this risk, theres an addLiquidity function in the router.
However, its uncertain what will happen if users directly call this function.
And there is also no minimum shares check.
And transferFrom is not used to transfer base and quote tokens from msg.sender to this MagicLP.
While these approaches may present vulnerabilities, they can be mitigated when these functions including buyShares and sellShares are called from the router, as the router performs relevant checks.
Please ensure that these functions can only be invoked from the router.
