Submitted by immeas
https://github.com/Tapioca-DAO/tap-token/blob/20a83b1d2d5577653610a6c3879dff9df4968345/contracts/options/TapiocaOptionBroker.sol#L408-L414
https://github.com/Tapioca-DAO/tap-token/blob/20a83b1d2d5577653610a6c3879dff9df4968345/contracts/options/TapiocaOptionBroker.sol#L292-L298
The finding itself is a follow up on the C4 finding #189. The description of the issue can be found in the Spearbit report.
The mitigation introduced in the PR seems lost in the code base at audit here.
Quoting the impact from the Spearbit report:
Test showing the issue is still there in tap-token/test/OptionTest.t.sol:
The full test file with setup can be found here
Consider re-applying the same fix that was acknowledged in the Spearbit audit.
Timing
0xRektora (Tapioca) confirmed
cryptotechmaker (Tapioca) commented:
