Submitted by deadrxsezzz
Since Magnetar is supposed to be used as a router for multiple operations, it can be expected that user will have it pre-approved for their NFTs (such as tOLP as oTAP ones, as theyll be the ones primarily used).
The Magnetar contract allows for any user to make a ERC721.approve, via _processPermitOperation:
The problem is that for OZ ERC721s (such as oTAP and tOLP), if an NFT owner has approved a spender as isApprovedForAll, the spender can call approve for any NFTs belonging to the owner.
In other words, if user A has set Magnetar as approvedForAll, user B can call NFT.approve(userB, id) and get access to user As NFT:
Do not allow users to make a call with  ERC721.approve selector.
0xWeiss (Tapioca) confirmed
