Submitted by vnavascues, also found by ether_sky, 0xRobocop, and haxatron
https://github.com/code-423n4/2024-01-salty/blob/main/src/dao/DAO.sol#L180 
https://github.com/code-423n4/2024-01-salty/blob/main/src/dao/DAO.sol#L219 
https://github.com/code-423n4/2024-01-salty/blob/main/src/dao/DAO.sol#L219
The DAO._executeApproval function does not handle an external contract call error:
Given an approved CALL_CONTRACT ballot that can be finalized, the ballot wont be marked as finalized if the external contract call (from above) reverts.
A permanent revert leaves the ballot unfinalized, and the user that posted it with an active proposal (in the _userHasActiveProposal mapping); a state that prevents the user account from creating a new proposal. At this point the user has two options to sort out the situation:
A. Unstake and transfer its SALT into a new account.
B. Convince the other users to reach quorum on NO and finalize the ballot without calling the external contract.
New contract to be created in /src/dao/tests:
Add the following test in DAO.t.sol:
A trivial solution is to handle the reverted external contract call with a try..catch and allow to always mark the approved ballot as finalized. A new ballot can always be created if the desired effects of the call were not applied on the first call.
Amend the CALL_CONTRACT case in the DAO._executeApproval function:
Add the following test in DAO.t.sol:
othernet-global (Salty.IO) confirmed and commented:
Note: For full discussion, see here.
Status: Mitigation confirmed. Full details in reports from t0x1c, 0xpiken, and [zzebra83].
