Submitted by juancito, also found by oakcobalt, trachev, and evmboi32
All assets from rentals pre-upgrade will be locked. Users cant recover them as old rentals cant be stopped.
The protocol has a functionality to upgrade modules via Kernel::executeAction().
That upgrade functionality performs some checks, initializes the new modules, and reconfigures policies, but it doesnt migrate any data, nor transfer any assets.
Modules can hold assets, such as in the case of the PaymentEscrow, as well as keeping rentals states in storage.
The current implementation of the PaymentEscrow for example doesnt have any mechanism for migrations, or to stop rentals, or withdraw assets if the module was upgraded via executeAction().
This will result in all previous rentals assets being locked, as rentals can no longer be stopped.
The following POC proves that old rentals cant be stopped, as well as showing how the old contract is still holding the users funds.
Create a new test in smart-contracts/test/integration/Upgrade.t.sol with this code:
Provide a method for users to migrate old rentals to the upgraded contracts, such as a migrate() function, executable by them or the protocol.
Another way is to provide a way to stop all rentals before the upgrade, in order to start with a fresh new module, or allow users to stop rentals from old modules.
Alec1017 (reNFT) acknowledged, but disagreed with severity and commented:
0xean (Judge) commented:
Alec1017 (reNFT) commented:
0xean (Judge) commented:
Alec1017 (reNFT) commented:
