Submitted by plasmablocks, also found by serial-coder, 0xabhay, BARW, and hals
When an order is created on Opensea the Create::validateOrder() policy method is used to ensure the order is configured correctly. Currently there is no maximum limit to the number of offers in the input ZoneParameters, which allows orders to contain an arbitrary amount of ERC-721 and ERC-1155 items to a rental order.
If a large enough rental order is successfully created, there is a risk that it wont be able to be stopped by calling the Stop::stopRent() due to the amount of gas required exceeding the block gas limit. This would prevent the escrow from settling the order and leave the order permantanly in a rental state. This also means any ERC-721 and ERC-1155 tokens in the order would not be able to be reclaimed.
This situation arises under the following conditions:
Below I have written 2 proof of concepts to show the above conditions are possible. Each of these can be added to StopRent.t.sol to run.
Foundry
Limit the number of offers that an order can contain (to a value such as 500 or 1000) to ensure that stopping rentals doesnt exceed the blocks gas limit. One way to do this is to enforce a maximum number of SpentItem[] offer and fail to create the order if it is exceeded.
Alec1017 (reNFT) acknowledged
Note: To see full discussion, see here.
