Submitted by kutugu, also found by 0xMAKEOUTHILL, pkqs90 (1, 2), zxriptor, visualbits, d3e4, Tychai0s, peritoflores, 0x0bserver, kuprum, xiao, dimulski, McToady, SovaSlava, Aymen0909, anshujalan, Zach_166, rouhsamad, Kose, 0xAadi, nonseodion, nazirite, Soul22, TermoHash, ether_sky (1, 2, 3), whoismatthewmc1, 0xmystery (1, 2, 3), HChang26, FastChecker, jacopod, AgileJune, matejdb (1, 2), ubermensch, Mike_Bello90 (1, 2), btk, Varun_05, santipu_, 0xPhantom, DarkTower, codegpt, sl1, KingNFT, almurhasan, erosjohn, Cosine, zhaojie, Topmark, dd0x7e8, UbiquitousComputing, Lalanda, mahdirostami, XORs33r, PENGUN, jasonxiale, pep7siup, lukejohn (1, 2, 3), dopeflamingo, osmanozdemir1, spacelord47, 0xLogos, fishgang (1, 2), alexfilippov314, SpicyMeatball, DanielArmstrong, zhaojohnson, aslanbek, hals, BowTiedOriole, Bobface, wangxx2026, nmirchev8, L0s1, KupiaSec, Oxsadeeq, BugzyVonBuggernaut, klau5, ke1caM, Soliditors, ZanyBonzy, EV_om, 0x111, cccz, bronze_pickaxe, Stormreckson, twcctop, deepplus, Inference (1, 2), AlexCzm, alexbabits, Kow, rvierdiiev, AS, Krace, and haxatron (1, 2)
onBalanceChange does not help to claim the previous rewards, but directly resets userFeeOffset, causing the users unclaimed rewards to be cleared.
The above POC shows that when a user purchases the same token twice, the first reward is cleared.
Foundry
onBalanceChange should claim the previous rewards, and then resets userFeeOffset:
andresaiello (Curves) confirmed
alcueca (Judge) decreased severity to Medium and commented:
For this audit, 113 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by 0xmystery received the top score from the judge.
The following wardens also submitted reports: mrudenko, cheatc0d3, 0xStriker, McToady, DarkTower, XORs33r, MrPotatoMagic, grearlake, slvDev, 7ashraf, ether_sky, 0xStalin, 0xGreyWolf, erebus, lsaudit, btk, 0x111, Prathik3, Cosine, _eperezok, UbiquitousComputing, jasonxiale, merlinboii, osmanozdemir1, dd0x7e8, alexfilippov314, lukejohn, klau5, peanuts, m4ttm, John_Femi, fouzantanveer, 0xepley, ahmedaghadi, adeolu, Nachoxt17, d3e4, jatin_19, Josephdara_0xTiwa, mitev, karanctf, Nikki, Kose, ptsanev, Faith, imare, kiki, Aymen0909, spaghetticode_sentinel, JayShreeRAM, FastChecker, 0xhashiman, slylandro_star, hihen, 0xmuxyz, whoismatthewmc1, jacopod, Ryonen, Draiakoo, LeoGold, dimulski, opposingmonkey, polarzero, santipu_, 0xc0ffEE, almurhasan, jesjupyter, codegpt, sl1, DanielArmstrong, 0xE1, 0xprinc, zhaojie, ktg, hals, amaechieth, khramov, para8956, Shubham, Lalanda, Topmark, 0xfave, n1punp, pep7siup, spacelord47, danb, mahdirostami, nuthan2x, jovemjeune, zhaojohnson, 0xSwahili, cartlex_, SovaSlava, SpicyMeatball, Soliditors, BowTiedOriole, zaevlad, KmanOfficial, Bobface, KupiaSec, cats, developerjordy, Oxsadeeq, pkqs90, twcctop, deepplus, Inference, lil_eth, 0xMAKEOUTHILL, israeladelaja, ziyou-, and Tigerfrake.
