Submitted by crack-the-kelp, also found by crack-the-kelp, osmanozdemir1, T1MOH, tallo, 0xffchain, Stormy, jayfromthe13th, Aymen0909, bLnk, Pechenite, chaduke, roleengineer, ast3ros, jasonxiale, deth, ZanyBonzy, zhaojie, 0xDING99YA, Bauchibred, lsaudit, deepkin, DanielArmstrong, and nmirchev8
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTOracle.sol#L70
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTDepositPool.sol#L49
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTDepositPool.sol#L84
https://github.com/code-423n4/2023-11-kelp/blob/main/src/NodeDelegator.sol#L122-L123
If there is update in strategy, getTotalAssetDeposits(asset) will reduce for asset. Because it checks for the assets deposited in NodeDelegator. NodeDelegator.getAssetBalance() will check for asset balance for the strategy of the user. If strategy is updated, then the balance of old strategy wont be taken into account which will reduce the totalDeposits. This will reduce the rsETH share price and cause more rsETH shares to be minted for the depositors. Thus, depositors can immediately deposit and their shares are worth more than their deposit.
Foundry
While updating the strategy, ensure that balance deposited in previous strategy for same asset is accounted while minting the shares.
ERC4626
gus (Kelp) disputed and commented:
manoj9april (Kelp) commented:
0xDjango (judge) invalidated and commented:
radev_sw (warden) commented:
manoj9april (Kelp) commented:
0xDjango (judge) increased severity to Medium and commented:
