Submitted by henry
Note: This finding was reported via the winning Automated Findings report. It was declared out of scope for the audit, but is being included here for completeness.
Not all ERC20 implementations revert() when theres a failure in transfer() or transferFrom(). The function signature has a boolean return value and they indicate errors that way instead. By not checking the return value, operations that should have marked as failed, may potentially go through without actually transfer anything.
Some tokens do not implement the ERC20 standard properly. For example, Tether (USDT)s transfer() and transferFrom() functions do not return booleans as the ERC20 specification requires, and instead have no return value. When these sorts of tokens are cast to IERC20/ERC20, their function signatures do not match and therefore the calls made will revert.
It is recommended to use the SafeERC20s safeTransfer() and safeTransferFrom() from OpenZeppelin instead.
There is 1 instance of these issues:
WildcatSanctionsEscrow.sol (#L38)
laurenceday (Wildcat) confirmed and commented:
0xTheC0der (judge) commented:
For this audit, 42 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by J4X received the top score from the judge.
The following wardens also submitted reports: radev_sw, serial-coder, VAD37, MiloTruck, osmanozdemir1, t0x1c, 3docSec, ggg_ttt_hhh, inzinko, 0xbepresent, Fulum, Phantom, 0xComfyCat, Udsen, DeFiHackLabs, nonseodion, Mike_Bello90, devival, karanctf, DavidGiladi, jasonxiale, ast3ros, josieg_74497, ZdravkoHr, deth, ke1caM, 0xStalin, YusSecurity, 0x3b, GREY-HAWK-REACH, caventa, Drynooo, nisedo, SHA_256, deepkin, InAllHonesty, 0xCiphky, rvierdiiev, nobody2018, MatricksDeCoder, and T1MOH.
