Submitted by ABA, also found by 0xmystery
When implementing EIP712, among other things, for data structures that will be a part of signing message, a typehash must be defined.
The structure typehash is defined as: typeHash = keccak256(encodeType(typeOf(s)))
Where encodeType is the type of a struct that is encoded as: name  "("  member  ","  member  ","    member ")"
And each member is written as: type  " "  name.
The project uses 2 structures on the signed data Transaction and Validation declared in TypeHashHelper:
However, the precalculated typehash for each of the structure are of different structures:
The issue went undetected in the initial development phase, and can be verified, because the tests still use the old hashes:
The specific test can be verified by running:
Protocol is not EIP712 compliant, which will result in issues with integrators.
An online keccak256 checker for validating that the those hashes are not actually for the correct structures.
Modify the structure typehash (and tests) to point to the correct structures.
0xad1onchain (Brahma) confirmed
0xsomeone (judge) commented:
0xad1onchain (Brahma) commented:
