Submitted by alexxander, also found by 3docSec
https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/MulticallRootRouter.sol#L163-L171
https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/MulticallRootRouter.sol#L186-L194
https://github.com/code-423n4/2023-09-maia/blob/f5ba4de628836b2a29f9b5fff59499690008c463/src/RootBridgeAgent.sol#L311-L315
Funds cannot be redeemed and remain stuck in a settlement.
In MulticallRootRouter, execute() calls _approveAndCallOut(...); however, it passes the Output Params recipient also as the refundee. This is dangerous because the recipient Dapp on the BranchChain can have a different address or not exist on the Root Chain. Therefore, if a settlement fails, it wont be able to be redeemed since the settlement owner is set as the refundee.
Here is a scenario:
Include an argument that enables users to specify the refundee when creating settlements without using a Virtual Account.
Context
0xLightt (Maia) confirmed
0xBugsy (Maia) commented:
Note: for full discussion, see here.
