Submitted by bin2chen, also found by maanas, nobody2018, castle_chain, mert_eren, and merlin
In AxelarRouter.sol, we need to ensure the legitimacy of the execute() method execution, mainly through two methods:
Lets look at the implementation of onlyCentrifugeChainOrigin():
The problem is that this restriction msg.sender == address(axelarGateway).
When we look at the official axelarGateway.sol contract, it doesnt provide any call external contract sexecute() method.
So msg.sender cannot be axelarGateway, and the official example does not restrict msg.sender.
The security of the command can be guaranteed by axelarGateway.validateContractCall(), sourceChain, sourceAddress.
There is no need to restrict msg.sender.
axelarGateway code address
https://github.com/axelarnetwork/axelar-cgp-solidity/blob/main/contracts/AxelarGateway.sol
Cant find anything that calls router.execute().
router.execute() cannot be executed properly, resulting in commands from other chains not being executed protocol not working properly.
Remove msg.sender restriction
Context
hieronx (Centrifuge) confirmed
gzeon (judge) increased severity to High and commented:
gzeon (judge) decreased severity to Medium and commented:
hieronx (Centrifuge) commented:
