Submitted by cccz
cancel() does not allow to cancel proposals in the final states Canceled/Defeated/Expired/Executed/Vetoed.
The Canceled/Executed/Vetoed states are final because they cannot be changed once they are set.
The Defeated state is also a final state because no new votes will be cast (stateInternal() may return Defeated only if the objectionPeriodEndBlock is passed).
But the Expired state depends on the GRACE_PERIOD of the timelock, and GRACE_PERIOD may be changed due to upgrades. Once the GRACE_PERIOD of the timelock is changed, the state of the proposal may also be changed, so Expired is not the final state.
Consider the following scenario:
https://github.com/nounsDAO/nouns-monorepo/blob/718211e063d511eeda1084710f6a682955e80dcb/packages/nouns-contracts/contracts/governance/NounsDAOV3Proposals.sol#L571-L581
Consider adding a proposal expiration time field in the Proposal structure.
eladmallel (Nouns DAO) acknowledged and commented:
gzeon (judge) decreased severity to Low/Non-Critical
eladmallel (Nouns DAO) commented:
gzeon (judge) commented:
eladmallel (Nouns DAO) commented:
cccz (warden) commented:
gzeon (judge) increased severity to Medium and commented:
For this audit, 12 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by shark received the top score from the judge.
The following wardens also submitted reports: Kaysoft, codegpt, MohammedRizwan, klau5, nadin, 0xMilenov, ihtishamsudo, descharre, fatherOfBlocks, koxuan, and Bauchibred.
