Submitted by 0xWaitress
At MultiRewardDistributor, different rewards token can be set up for each mToken, which is the assetToken or debtToken of the lending protocol. When a reward token is set up, its emission speed cannot be bigger than the emissionCap (100 * 1e18 as suggested in the code comment). However since multiple reward tokens may be set up, and they may have different decimal places, for example USDT has a decimal of 6 and GUSD even has a decimal of 2 they are virtually not bounded by such emissionCap.
On the contract, tokens with more than 18 decimal would not be practically emitted. This one-size-fit-all emissionCap might create obstacles for the protocol to effectively manage each rewardTokens.
https://github.com/code-423n4/2023-07-moonwell/blob/main/src/core/MultiRewardDistributor/MultiRewardDistributor.sol#L703-L725
Consider creating emissionCap for each rewardTokens so they can be adapted based on their own decimals.
ElliotFriedman (Moonwell) confirmed, but disagreed with severity and commented:
alcueca (Judge) commented:
ElliotFriedman (Moonwell) commented:
alcueca (Judge) commented:
lyoungblood (Warden) commented:
