Submitted by MiloTruck, also found by juancito
When the LensHub contract has been paused by governance (_state set to ProtocolState.Paused), users should not be able unfollow profiles. This can be inferred as the unfollow() function has the whenNotPaused modifier:
LensHub.sol#L368-L371
However, in the FollowNFT contract, which is deployed for each profile that has followers, the removeFollower() and burn() functions do not check if the LensHub contract is paused:
FollowNFT.sol#L131-L138
FollowNFT.sol#L255-L258
As such, whenever the system has been paused by governance, users will still be able to unfollow profiles by wrapping their followNFT and then calling either removeFollower() or burn().
Users are able to unfollow profiles when the system is paused, which they should not be able to do.
This could be problematic if governance ever needs to temporarily pause unfollow functionality (eg. for a future upgrade, or unfollowing functionality has a bug, etc).
The Foundry test below demonstrates how users will still be able to unfollow profiles by calling wrap() and removeFollower(), even after the system has been paused by governance. It can be run with the following command:
All FollowNFT contracts should check that the LensHub contract isnt paused before allowing removeFollower() or burn() to be called. This can be achieved by doing the following:
FollowNFT.sol#L131-L138
FollowNFT.sol#L255-L258
Access Control
donosonaumczuk (Lens) disagreed with severity and commented:
Picodes (judge) decreased severity to Low
juancito (warden) commented via duplicate issue #108:
donosonaumczuk (Lens) commented via duplicate issue #108:
Picodes (judge) increased severity to Medium and commented via duplicate issue #108:
