Submitted by 0x52
Selling bonds with coupons that are already accounted will fail unexpectedly.
https://github.com/code-423n4/2023-02-kuma/blob/3f3d2269fcb3437a9f00ffdd67b5029487435b95/src/kuma-protocol/KUMASwap.sol#L116-L118
The above lines will cause ALL bonds sales to revert when _coupons.length has reached _maxCoupons. Since bonds may share the same coupon, the swap should continue to accept bonds with a coupon that already exist in the _coupons set.
sellBond should only revert if the max length has been reached and bond.coupon doesnt already exist:
m19 (KUMA) confirmed and commented:
Alex the Entreprenerd (judge) commented:
For this contest, 4 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by 0xsomeone received the top score from the judge.
The following wardens also submitted reports: 0x52, hihen, and bin2chen.
