Submitted by fs0c
https://github.com/reserve-protocol/protocol/blob/df7ecadc2bae74244ace5e8b39e94bc992903158/contracts/p1/StRSR.sol#L803
https://github.com/reserve-protocol/protocol/blob/df7ecadc2bae74244ace5e8b39e94bc992903158/contracts/p1/StRSR.sol#L791
In StRSR.sol the _domainSeparatorV4 is calculated using the EIP-721 standard, which uses the name and version that are passed in the init at the function call __EIP712_init(name, "1");
Now, governance can change this name anytime using the following function:
After that call the domain separator would still be calculated using the old name, which shouldnt be the case.
The permit transactions and vote delegation would be reverted if the domain separator is wrong.
While changing the name in setName function, update the domain separator.
tbrent (Reserve) confirmed
tbrent (Reserve) mitigated:
Status: Mitigation confirmed. Full details in reports from HollaDieWaldfee, 0xA5DF, and AkshaySrivastav.
